Open
Conversation
Cast int values before save
| if ($b) { | ||
| $app = Application::getFacadeApplication(); | ||
| /** @var Connection $connection */ | ||
| $connection = $app->make(Connection::class); |
Member
There was a problem hiding this comment.
Can this be a hard dependency of this class instead of relying on the service locator? IE:
protected $db;
public function __construct(Connection $db)
{
$this->db = $db;
}
Comment on lines
54
to
62
| if ($column->getName() === $key) { | ||
| if ($column->getType()->getName() === Type::INTEGER) { | ||
| if ($column->getNotnull()) { | ||
| $value = (int) $value; | ||
| } else { | ||
| $value = $value === null ? null : (int) $value; | ||
| } | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
Suggested change
| if ($column->getName() === $key) { | |
| if ($column->getType()->getName() === Type::INTEGER) { | |
| if ($column->getNotnull()) { | |
| $value = (int) $value; | |
| } else { | |
| $value = $value === null ? null : (int) $value; | |
| } | |
| } | |
| } | |
| if ( | |
| $column->getName() !== $key || | |
| $column->getType()->getName() === Type::INTEGER | |
| ) { | |
| continue; | |
| } | |
| $value = ($column->getNotNull() || $column !== null) : (int) $value : null; | |
| break; |
Using an early return (early continue) is more readable to me here, also worth breaking when the proper column is matched
Contributor
Author
|
Done. (BC note: If someone created a custom publisher that uses StandardPublisher as fallback, they must change their code) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #102, #57, #47
This PR converts values to integers when the table column type is an integer.
You can test this fix by adding an image slider block with entries with no images selected.